Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid comments on closed / merged pull-requests #62

Merged
merged 8 commits into from
Dec 12, 2024
Merged

fix: avoid comments on closed / merged pull-requests #62

merged 8 commits into from
Dec 12, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Dec 10, 2024 •
edited
Loading

Resolves #60
QA: Meniole#7

@github-actions GitHub Actions
Copy link
Contributor

Unused dependencies (1)

Filename dependencies
package.json hono

@gentlementlegen gentlementlegen marked this pull request as ready for review December 12, 2024 11:35
@0x4007 0x4007 requested a review from rndquu December 12, 2024 16:38
0x4007
0x4007 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense. The QA I get a bit confused reviewing but nothing stands out to me as a mistake.

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Dec 12, 2024 •
edited
Loading

@0x4007 Sorry a bit tricky to test. What should be noticed is that the closed pull-request didn't get any reminders while the drafted one did, which is what was intended to be fixed here. Let me test it while having the two pull-requests closed to make sure all scenarios work as expected (should comment on the main issue).

Result: it worked fine as seen here, but I think the user should have been disqualified because closed / merged pull-requests should not count as work ongoing very likely, lemme fix that.

Fixed message for reminder < 1 hour, fixed the instant disqualify if there are only closed PRs: Meniole#7 (comment)

@gentlementlegen gentlementlegen merged commit a26b2b1 into ubiquity-os-marketplace:development Dec 12, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the fix/reminders branch December 12, 2024 19:09
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

@whilefoo whilefoo Awaiting requested review from whilefoo

@rndquu rndquu Awaiting requested review from rndquu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: follow up on completed task
2 participants
@gentlementlegen @0x4007